[GitHub] [drill] ihuzenko commented on a change in pull request #1981: DRILL-7583: Remove STOP status from operator outcome

[GitBox]

ihuzenko commented on a change in pull request #1981: DRILL-7583: Remove STOP 
status from operator outcome
URL: https://github.com/apache/drill/pull/1981#discussion_r379480608
 
 

 ##########
 File path: 
exec/java-exec/src/main/java/org/apache/drill/exec/physical/impl/join/HashJoinMemoryCalculatorImpl.java
 ##########
 @@ -361,13 +358,13 @@ private void calculateMemoryUsage()
         partitionProbeBatchSize = 
probeSizePredictor.predictBatchSize(recordsPerPartitionBatchProbe, reserveHash);
       }
 
-      maxOutputBatchSize = (long) ((double)outputBatchSize * 
fragmentationFactor * safetyFactor);
+      maxOutputBatchSize = (long) (outputBatchSize * fragmentationFactor * 
safetyFactor);
 
       long probeReservedMemory = 0;
 
       for (partitions = initialPartitions;; partitions /= 2) {
         // The total amount of memory to reserve for incomplete batches across 
all partitions
-        long incompletePartitionsBatchSizes = ((long) partitions) * 
partitionBuildBatchSize;
+        long incompletePartitionsBatchSizes = (partitions) * 
partitionBuildBatchSize;
 
 Review comment:
   ```suggestion
           long incompletePartitionsBatchSizes = partitions * 
partitionBuildBatchSize;
   ```

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services