ihuzenko commented on a change in pull request #1981: DRILL-7583: Remove STOP
status from operator outcome
URL: https://github.com/apache/drill/pull/1981#discussion_r379438348
##########
File path:
exec/java-exec/src/main/java/org/apache/drill/exec/physical/impl/join/HashJoinBatch.java
##########
@@ -515,99 +536,95 @@ public HashJoinMemoryCalculator getCalculatorImpl() {
@Override
public IterOutcome innerNext() {
if (wasKilled) {
- // We have received a kill signal. We need to stop processing.
- this.cleanup();
- super.close();
+ // We have received a cancel signal. We need to stop processing.
+ cleanup();
return IterOutcome.NONE;
}
prefetchFirstBuildBatch();
if (rightUpstream.isError()) {
- // A termination condition was reached while prefetching the first build
side data holding batch.
+ // A termination condition was reached while prefetching the first build
+ // side data holding batch.
Review comment:
merge with line below
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
With regards,
Apache Git Services
