paul-rogers commented on a change in pull request #1981: DRILL-7583: Remove STOP status from operator outcome URL: https://github.com/apache/drill/pull/1981#discussion_r379848754
########## File path: exec/java-exec/src/main/java/org/apache/drill/exec/physical/impl/join/HashJoinBatch.java ########## @@ -386,52 +398,52 @@ protected void buildSchema() { * Prefetches the first build side data holding batch. */ private void prefetchFirstBuildBatch() { - rightUpstream = prefetchFirstBatch(rightUpstream, - prefetchedBuild, - buildSideIsEmpty, - RIGHT_INDEX, - buildBatch, - () -> { - batchMemoryManager.update(RIGHT_INDEX, 0, true); - RecordBatchStats.logRecordBatchStats(RecordBatchIOType.INPUT_RIGHT, - batchMemoryManager.getRecordBatchSizer(RIGHT_INDEX), - getRecordBatchStatsContext()); - }); + rightUpstream = prefetchFirstBatch(rightUpstream, prefetchedBuild, + buildSideIsEmpty, RIGHT_INDEX, buildBatch, () -> { + batchMemoryManager.update(RIGHT_INDEX, 0, true); + RecordBatchStats.logRecordBatchStats(RecordBatchIOType.INPUT_RIGHT, + batchMemoryManager.getRecordBatchSizer(RIGHT_INDEX), + getRecordBatchStatsContext()); + }); Review comment: Good suggestion. For the most part, I tried not to tinker with the code here unless necessary. A few of the adjustments to remove STOP resulted in subtle errors that took hours to find. In general, this class (and several others) are trying to do too much: there are too many variables to think about. Better to split up responsibilities as I did years ago in the external sort. (For fun, go back and look at the original version.) ---------------------------------------------------------------- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services