paul-rogers commented on a change in pull request #2026: DRILL-7330: Implement
metadata usage for all format plugins
URL: https://github.com/apache/drill/pull/2026#discussion_r392610708
##########
File path:
exec/java-exec/src/main/java/org/apache/drill/exec/store/dfs/easy/EasyFormatPlugin.java
##########
@@ -315,16 +314,16 @@ private CloseableRecordBatch
buildScanBatch(FragmentContext context,
readers.add(recordReader);
final List<String> partitionValues = ColumnExplorer.listPartitionValues(
work.getPath(), scan.getSelectionRoot(), false);
- final Map<String, String> implicitValues =
columnExplorer.populateImplicitColumns(
- work.getPath(), partitionValues, supportsFileImplicitColumns);
+ final Map<String, String> implicitValues =
columnExplorer.populateImplicitAndInternalColumns(
+ work.getPath(), partitionValues, supportsFileImplicitColumns, dfs);
Review comment:
As we discussed, this can fail with the present design. We should catch the
exception and translate it to something useful for the user.
BTW: how might you test the missing file case so we can see what error is
returned? Maybe we need a way to inject an error when checking the modification
date?
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
With regards,
Apache Git Services
