[
https://issues.apache.org/jira/browse/FELIX-3202?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13145562#comment-13145562
]
Lucas Galfaso commented on FELIX-3202:
--------------------------------------
I would like to split this conversation into multiple easy-to-digest parts:
(1) I do not know about the spec history, why it changed or how it will change
if the future, so maybe there are other reasons that I am not aware of that
make more sense to keep the existing implementation as-is
(2) The proposed implementation has the benefit that it is easier to understand
(I know this is not objective and other people may think otherwise), the fact
that it uses Java 5 generics can be though as a plus. Maybe the description of
the issue has to be changed to reflect this
(3) It adds more classes, but from the point of view of lines of code, it is
just modestly larger (if you include the code at SimpleFilter and the code that
does the matching at CapabilitySet)
(4) It is a lot faster, the test show that matching takes about half the time
if you compare it with SimpleFilter, if the test is wrong and this result is
not representative, please let me know and I will work on fixing it
(5) I do not understand the comment "which is not what we want", it is my
understanding that between two alternatives that follow the standard, with
about the same number of lines of code and same complexity, the implementation
that is faster would be the alternative to follow. This is, even if one has 10
inner classes and the other no inner classes at all. Again, if this
understanding is wrong, please let me know
> Add generic type information to SimpleFilter
> --------------------------------------------
>
> Key: FELIX-3202
> URL: https://issues.apache.org/jira/browse/FELIX-3202
> Project: Felix
> Issue Type: Improvement
> Components: Framework
> Reporter: Lucas Galfaso
> Priority: Minor
> Attachments: felix_java5_filter.diff
>
>
> SimpleFilter does not have Java 5 generic type information and it is very
> hard to add this to the current implementation.
> Devise a way to add generate type information to SimpleFilter while keeping
> in mind that this is a critical component and any performance degradation
> would slow down the entire framework
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators:
https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira
