[
https://issues.apache.org/jira/browse/FELIX-3202?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13149189#comment-13149189
]
Lucas Galfaso commented on FELIX-3202:
--------------------------------------
I have a partial patch that handles the non-indexed and the indexed scenario,
but the performance improvements are not as big as before and depends if we
only look for all elements in an index (about the same speed) to 15% if the
filter is slightly more complex (there are other cases where the improvement is
much bigger but I think will be less common scenarios.)
Note: In the tests performed I did put the attribute that is indexed first as
the current implementation has some issues if that is not the case.
BTW(1), the new implementation does not have this ordering issue so some small
hackery can be removed, but I think that would be just a minor plus if this
ever make it to trunk.
BTW(2), the current implementation makes the assumption that all fields that
are indexes appear in the filter using the same class. This is true for the
current uses of CapabilitySet as the value of the indexed fields will always be
Strings at SimpleFilter (even when a SimpleFilter may have a Version in it's
value), this is now explicit in the new implementation.
Will post a new patch once I have a complete one that applies cleanly over
trunk.
> Add generic type information to SimpleFilter
> --------------------------------------------
>
> Key: FELIX-3202
> URL: https://issues.apache.org/jira/browse/FELIX-3202
> Project: Felix
> Issue Type: Improvement
> Components: Framework
> Reporter: Lucas Galfaso
> Priority: Minor
> Attachments: felix_java5_filter.diff
>
>
> SimpleFilter does not have Java 5 generic type information and it is very
> hard to add this to the current implementation.
> Devise a way to add generate type information to SimpleFilter while keeping
> in mind that this is a critical component and any performance degradation
> would slow down the entire framework
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators:
https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira
