[
https://issues.apache.org/jira/browse/FELIX-3202?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13146033#comment-13146033
]
Richard S. Hall commented on FELIX-3202:
----------------------------------------
(1) The spec won't change to eliminate matching by the filter, but it is still
the wrong approach when trying to optimize. It is the equivalent of giving each
row in a table to a SELECT and asking the SELECT if the row matches. This
doesn't make sense from an optimization point of view.
(2) This falls into the "eye of the beholder", so I'm not sure how to quantify.
(3) Due to spending lots of time programming with class loaders, I tend to
worry about number of classes and number of class loads, not lines of code.
(4) I'm not sure how the tests were performed, but most of the time filters are
run against a CapabilitySet which maintains indices, so I'd be surprised if 50%
faster. If you are talking purely about un-indexed matching, then let's work on
improving the match operation.
(5) SimpleFilter is an implementation detail of the framework which is used to
implement Filter for the OSGi. However, its primary purpose is to be used
internally by the framework resolver to match capabilities to requirements. The
internal dependency model of the Felix framework is based on a generic
dependency model built on top of SimpleFilter, which requires that we reverse
the matching to introduce indices, much like a database.
> Add generic type information to SimpleFilter
> --------------------------------------------
>
> Key: FELIX-3202
> URL: https://issues.apache.org/jira/browse/FELIX-3202
> Project: Felix
> Issue Type: Improvement
> Components: Framework
> Reporter: Lucas Galfaso
> Priority: Minor
> Attachments: felix_java5_filter.diff
>
>
> SimpleFilter does not have Java 5 generic type information and it is very
> hard to add this to the current implementation.
> Devise a way to add generate type information to SimpleFilter while keeping
> in mind that this is a critical component and any performance degradation
> would slow down the entire framework
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators:
https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira
