[
https://issues.apache.org/jira/browse/FLUME-1100?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13447067#comment-13447067
]
Chris Birchall commented on FLUME-1100:
---------------------------------------
Hi Ted, thanks for the patch.
I think your patch and mine do basically the same thing. The only difference is
that using your patch the user sets "hdfs.writeFormat" to the class name of a
FlumeFormatter implementation, whereas with my patch they set it to the class
name of a Builder.
The nice thing about using a Builder is that we can pass a configuration
Context to its build() method, so we can supply custom configuration parameters
for our FlumeFormatter in the Flume config file.
e.g.
agent_foo.sinks.hdfs-sink.writeFormat=com.mycompany.flume.MyCustomFormatter$Builder
agent_foo.sinks.hdfs-sink.writeFormat.ignoreHeaders=foo,bar
agent_foo.sinks.hdfs-sink.writeFormat.maxEventLengthBytes=10000
> HDFSWriterFactory and HDFSFormatterFactory should allow extension
> -----------------------------------------------------------------
>
> Key: FLUME-1100
> URL: https://issues.apache.org/jira/browse/FLUME-1100
> Project: Flume
> Issue Type: Improvement
> Affects Versions: v1.1.0
> Reporter: Brock Noland
> Attachments: FLUME-1100-pluggable-FlumeFormatter.patch,
> FLUME-1100-upgraded-factory.patch
>
>
> Users should be able to plugin a class for both factories
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators
For more information on JIRA, see: http://www.atlassian.com/software/jira
