[ 
https://issues.apache.org/jira/browse/FLUME-1100?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13447447#comment-13447447
 ] 

Chris Birchall commented on FLUME-1100:
---------------------------------------

Yes, I think HDFSWriterFactory should be re-written in the same way:

* Replace the hardcoded strings with an enum
* Use a builder instead of direct construction

I was planning to do this myself, but I was hoping to get some kind of comment 
from somebody core to the project before writing too much code. I'm not sure if 
I'm supposed to formally request a review, or if the review system is only for 
committers.
                
> HDFSWriterFactory and HDFSFormatterFactory should allow extension
> -----------------------------------------------------------------
>
>                 Key: FLUME-1100
>                 URL: https://issues.apache.org/jira/browse/FLUME-1100
>             Project: Flume
>          Issue Type: Improvement
>    Affects Versions: v1.1.0
>            Reporter: Brock Noland
>         Attachments: FLUME-1100-pluggable-FlumeFormatter.patch, 
> FLUME-1100-upgraded-factory.patch
>
>
> Users should be able to plugin a class for both factories

--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators
For more information on JIRA, see: http://www.atlassian.com/software/jira

Reply via email to