[ 
https://issues.apache.org/jira/browse/FLUME-1100?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13447658#comment-13447658
 ] 

Ted Malaska commented on FLUME-1100:
------------------------------------

Hey Hari,

(1) Summarization: What started out as a issue to allow the users to inject 
custom formatters into Flume HDFSEventSink, turned into a discussion on how 
Flume as a whole will allow injection of custom classes. i.e. formatters, 
writers, EventSerializers, ...

(2) Which patch: Now Chris's initial patch is still the winner because it 
strives to be consistant with existing injection code in Flume (i.e 
EventSerializers).  But Chris's patch only focuses on injection of the 
formatter where as we both agree if this builder pattern is selected as the 
standard for flume then the patch is just the beginning of something much 
bigger.  In that the builder pattern becomes the universal way in which things 
are injected.  So things like the writer injection should also follow the same 
builder pattern.

(3) Summary of other topics: You will also find in the above talks a discussion 
about the difference between the builder pattern and the Configurable interface 
pattern from Hadoop.  

                
> HDFSWriterFactory and HDFSFormatterFactory should allow extension
> -----------------------------------------------------------------
>
>                 Key: FLUME-1100
>                 URL: https://issues.apache.org/jira/browse/FLUME-1100
>             Project: Flume
>          Issue Type: Improvement
>    Affects Versions: v1.1.0
>            Reporter: Brock Noland
>         Attachments: FLUME-1100-pluggable-FlumeFormatter.patch, 
> FLUME-1100-upgraded-factory.patch
>
>
> Users should be able to plugin a class for both factories

--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators
For more information on JIRA, see: http://www.atlassian.com/software/jira

Reply via email to