[ 
https://issues.apache.org/jira/browse/FLUME-1100?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13447444#comment-13447444
 ] 

Ted Malaska commented on FLUME-1100:
------------------------------------

Agreed. There should be a consistent way of building these types of objects and 
you are being consistent with EventSerializer.  So your approach is more 
correct.

Now in the thought of making things consistent I have a question about 
writerFactory.  Why does the existing implementation allow writerFactory to be 
passed in through a constructor but doesn't allow the same for the 
formatterFactory?  

Does it make since for both of these factories to follow your builder pattern?

                
> HDFSWriterFactory and HDFSFormatterFactory should allow extension
> -----------------------------------------------------------------
>
>                 Key: FLUME-1100
>                 URL: https://issues.apache.org/jira/browse/FLUME-1100
>             Project: Flume
>          Issue Type: Improvement
>    Affects Versions: v1.1.0
>            Reporter: Brock Noland
>         Attachments: FLUME-1100-pluggable-FlumeFormatter.patch, 
> FLUME-1100-upgraded-factory.patch
>
>
> Users should be able to plugin a class for both factories

--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators
For more information on JIRA, see: http://www.atlassian.com/software/jira

Reply via email to