----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/49453/#review140746 -----------------------------------------------------------
flume-ng-core/src/main/java/org/apache/flume/formatter/output/BucketPath.java (lines 192 - 198) <https://reviews.apache.org/r/49453/#comment206109> nit: indention should be 2 spaces flume-ng-core/src/main/java/org/apache/flume/formatter/output/BucketPath.java (line 239) <https://reviews.apache.org/r/49453/#comment206108> You worried in the corresponding jira about using timezone in rounding might affect users already adopted to the now changed behaviour. Was this concern addressed? Was it ever considered to introduce jodatime to flume? (http://www.joda.org/joda-time/) - Attila Simon On July 1, 2016, 11:18 a.m., Denes Arvay wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/49453/ > ----------------------------------------------------------- > > (Updated July 1, 2016, 11:18 a.m.) > > > Review request for Flume, Balázs Donát Bessenyei and Attila Simon. > > > Bugs: FLUME-2725 > https://issues.apache.org/jira/browse/FLUME-2725 > > > Repository: flume-git > > > Description > ------- > > Patch for FLUME-2725 - HDFS Sink does not use configured timezone for rounding > > > Diffs > ----- > > > flume-ng-core/src/main/java/org/apache/flume/formatter/output/BucketPath.java > b2fe3f0 > > flume-ng-core/src/main/java/org/apache/flume/tools/TimestampRoundDownUtil.java > daa9606 > > flume-ng-core/src/test/java/org/apache/flume/formatter/output/TestBucketPath.java > 21b972b > > flume-ng-core/src/test/java/org/apache/flume/tools/TestTimestampRoundDownUtil.java > cc7eac0 > > Diff: https://reviews.apache.org/r/49453/diff/ > > > Testing > ------- > > `org.apache.flume.formatter.output.TestBucketPath` and > `org.apache.flume.tools.TestTimestampRoundDownUtil` were extended with new > methods testing with `TimeZone`. Existing and new tests pass. > > > Thanks, > > Denes Arvay > >
