----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/49453/#review141772 -----------------------------------------------------------
Mind rebasing on trunk? If you run mvn clean verify -DskipTests -Drat.skip then checkstyle will run and you will know if there are any style violations. At least, that is the fastest way I know of to do the style check. I'll wait for Attila to finish reviewing this before picking it back up myself for a final review. - Mike Percy On July 1, 2016, 4:18 a.m., Denes Arvay wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/49453/ > ----------------------------------------------------------- > > (Updated July 1, 2016, 4:18 a.m.) > > > Review request for Flume, Balázs Donát Bessenyei and Attila Simon. > > > Bugs: FLUME-2725 > https://issues.apache.org/jira/browse/FLUME-2725 > > > Repository: flume-git > > > Description > ------- > > Patch for FLUME-2725 - HDFS Sink does not use configured timezone for rounding > > > Diffs > ----- > > > flume-ng-core/src/main/java/org/apache/flume/formatter/output/BucketPath.java > b2fe3f0 > > flume-ng-core/src/main/java/org/apache/flume/tools/TimestampRoundDownUtil.java > daa9606 > > flume-ng-core/src/test/java/org/apache/flume/formatter/output/TestBucketPath.java > 21b972b > > flume-ng-core/src/test/java/org/apache/flume/tools/TestTimestampRoundDownUtil.java > cc7eac0 > > Diff: https://reviews.apache.org/r/49453/diff/ > > > Testing > ------- > > `org.apache.flume.formatter.output.TestBucketPath` and > `org.apache.flume.tools.TestTimestampRoundDownUtil` were extended with new > methods testing with `TimeZone`. Existing and new tests pass. > > > Thanks, > > Denes Arvay > >
