> On July 5, 2016, 10:34 a.m., Attila Simon wrote: > > flume-ng-core/src/main/java/org/apache/flume/formatter/output/BucketPath.java, > > lines 192-198 > > <https://reviews.apache.org/r/49453/diff/1/?file=1434745#file1434745line192> > > > > nit: indention should be 2 spaces
there's a multi line assignment so it's a "continuation indent" which should be 4 spaces. > On July 5, 2016, 10:34 a.m., Attila Simon wrote: > > flume-ng-core/src/main/java/org/apache/flume/formatter/output/BucketPath.java, > > line 239 > > <https://reviews.apache.org/r/49453/diff/1/?file=1434745#file1434745line239> > > > > You worried in the corresponding jira about using timezone in rounding > > might affect users already adopted to the now changed behaviour. Was this > > concern addressed? Yes it was. It's a bug fix so we don't need to be backwards compatible. - Denes ----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/49453/#review140746 ----------------------------------------------------------- On July 1, 2016, 11:18 a.m., Denes Arvay wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/49453/ > ----------------------------------------------------------- > > (Updated July 1, 2016, 11:18 a.m.) > > > Review request for Flume, Balázs Donát Bessenyei and Attila Simon. > > > Bugs: FLUME-2725 > https://issues.apache.org/jira/browse/FLUME-2725 > > > Repository: flume-git > > > Description > ------- > > Patch for FLUME-2725 - HDFS Sink does not use configured timezone for rounding > > > Diffs > ----- > > > flume-ng-core/src/main/java/org/apache/flume/formatter/output/BucketPath.java > b2fe3f0 > > flume-ng-core/src/main/java/org/apache/flume/tools/TimestampRoundDownUtil.java > daa9606 > > flume-ng-core/src/test/java/org/apache/flume/formatter/output/TestBucketPath.java > 21b972b > > flume-ng-core/src/test/java/org/apache/flume/tools/TestTimestampRoundDownUtil.java > cc7eac0 > > Diff: https://reviews.apache.org/r/49453/diff/ > > > Testing > ------- > > `org.apache.flume.formatter.output.TestBucketPath` and > `org.apache.flume.tools.TestTimestampRoundDownUtil` were extended with new > methods testing with `TimeZone`. Existing and new tests pass. > > > Thanks, > > Denes Arvay > >
