On July 5, 2016, 10:34 a.m., Denes Arvay wrote:
> > Was it ever considered to introduce jodatime to flume? 
> > (http://www.joda.org/joda-time/)

Jodatime is already used in parts of Flume, so we may use it. See for example 
flume-ng-core/src/test/java/org/apache/flume/source/TestMultiportSyslogTCPSource.java


- Mike


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/49453/#review140746
-----------------------------------------------------------


On July 1, 2016, 11:18 a.m., Denes Arvay wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/49453/
> -----------------------------------------------------------
> 
> (Updated July 1, 2016, 11:18 a.m.)
> 
> 
> Review request for Flume, Balázs Donát Bessenyei and Attila Simon.
> 
> 
> Bugs: FLUME-2725
>     https://issues.apache.org/jira/browse/FLUME-2725
> 
> 
> Repository: flume-git
> 
> 
> Description
> -------
> 
> Patch for FLUME-2725 - HDFS Sink does not use configured timezone for rounding
> 
> 
> Diffs
> -----
> 
>   
> flume-ng-core/src/main/java/org/apache/flume/formatter/output/BucketPath.java 
> b2fe3f0 
>   
> flume-ng-core/src/main/java/org/apache/flume/tools/TimestampRoundDownUtil.java
>  daa9606 
>   
> flume-ng-core/src/test/java/org/apache/flume/formatter/output/TestBucketPath.java
>  21b972b 
>   
> flume-ng-core/src/test/java/org/apache/flume/tools/TestTimestampRoundDownUtil.java
>  cc7eac0 
> 
> Diff: https://reviews.apache.org/r/49453/diff/
> 
> 
> Testing
> -------
> 
> `org.apache.flume.formatter.output.TestBucketPath` and 
> `org.apache.flume.tools.TestTimestampRoundDownUtil` were extended with new 
> methods testing with `TimeZone`. Existing and new tests pass.
> 
> 
> Thanks,
> 
> Denes Arvay
> 
>

Reply via email to