> On July 12, 2016, 11:38 p.m., Mike Percy wrote: > > flume-ng-core/src/test/java/org/apache/flume/tools/TestTimestampRoundDownUtil.java, > > line 35 > > <https://reviews.apache.org/r/49453/diff/2/?file=1442147#file1442147line35> > > > > Isn't this just CET? This is the Hungarian time zone, right?
No, it's a nonexistent TZ, GMT + 1 millisecond. I was hesitating using a valid timezone and checking if it's not the system default (and choosing an other one in that case) but this solution seemed cleaner. > On July 12, 2016, 11:38 p.m., Mike Percy wrote: > > flume-ng-core/src/test/java/org/apache/flume/tools/TestTimestampRoundDownUtil.java, > > line 111 > > <https://reviews.apache.org/r/49453/diff/2/?file=1442147#file1442147line111> > > > > Doesn't this assertion fail if you run it while your clock is set to > > CET? No, as the `CUSTOM_TIMEZONE` is not CET. - Denes ----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/49453/#review141976 ----------------------------------------------------------- On July 13, 2016, 12:29 p.m., Denes Arvay wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/49453/ > ----------------------------------------------------------- > > (Updated July 13, 2016, 12:29 p.m.) > > > Review request for Flume, Balázs Donát Bessenyei and Attila Simon. > > > Bugs: FLUME-2725 > https://issues.apache.org/jira/browse/FLUME-2725 > > > Repository: flume-git > > > Description > ------- > > Patch for FLUME-2725 - HDFS Sink does not use configured timezone for rounding > > > Diffs > ----- > > > flume-ng-core/src/main/java/org/apache/flume/formatter/output/BucketPath.java > b2fe3f0 > > flume-ng-core/src/main/java/org/apache/flume/tools/TimestampRoundDownUtil.java > daa9606 > > flume-ng-core/src/test/java/org/apache/flume/formatter/output/TestBucketPath.java > b1b828a > > flume-ng-core/src/test/java/org/apache/flume/tools/TestTimestampRoundDownUtil.java > 1ac11ab > > Diff: https://reviews.apache.org/r/49453/diff/ > > > Testing > ------- > > `org.apache.flume.formatter.output.TestBucketPath` and > `org.apache.flume.tools.TestTimestampRoundDownUtil` were extended with new > methods testing with `TimeZone`. Existing and new tests pass. > > > Thanks, > > Denes Arvay > >
