+1 Sent from my iPhone
> On 6 May 2015, at 10:58, Pid <[email protected]> wrote: > >> On 01/05/2015 17:50, Dan Smith wrote: >>> On Fri, May 1, 2015 at 7:07 AM, jan i <[email protected]> wrote: >>> >>> Public feature branches should only be used, when multiple people work on a >>> feature. A feature branch is started after the intention is made clear on >>> dev@ > > Pushing a feature branch could be a simple way to offer it for review. > > I understand that Geode will be RTC (Review-Then-Commit), so we should > discuss how the review process will work in combination with git-flow. > > >> One thing we've done within our organization is make a distinction between >> public feature branches - which are longer lived with multiple committers, >> and "work in progress" branches for individual changes which are generally >> owned by a single committer and are very short lived. >> >> Would it make sense for committers to create work in progress branches on >> the apache github, or should these be maintained outside apache >> infastructure? > > As above, I think the mechanism by which proposed changes are to be > reviewed has some bearing here. > > > IMHO it doesn't make sense to maintain branches elsewhere, unless they > are solely in your local copy of the git repository and there's some > other mechanism for reviewing them before they are merged into the > develop branch on the origin repo. > > > Thoughts? > > > p > > > >> -Dan > > > -- > > [key:62590808]
