[GitHub] [geronimo-xbean] rmannibucau commented on a diff in pull request #34: XBEAN-337 jar path with exclamation signs(!) should be resolved correctly

[GitBox]

rmannibucau commented on code in PR #34:
URL: https://github.com/apache/geronimo-xbean/pull/34#discussion_r1051445859


##########
xbean-finder/src/test/java/org/apache/xbean/finder/archive/JarArchiveTest.java:
##########
@@ -63,12 +64,12 @@ public void setUp() throws Exception {
     public void testGetBytecode() throws Exception {
 
         for (Class clazz : classes) {
-            assertNotNull(clazz.getName(), 
archive.getBytecode(clazz.getName()));
+            Assert.assertNotNull(clazz.getName(), 
archive.getBytecode(clazz.getName()));

Review Comment:
   Sadly I think geronimo misses some shared config (to be frank I think it 
is/was also a good compromise but understand it can miss for contributions)



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: dev-unsubscr...@geronimo.apache.org

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org