rmannibucau commented on code in PR #34:
URL: https://github.com/apache/geronimo-xbean/pull/34#discussion_r1051446012
##########
xbean-finder/src/main/java/org/apache/xbean/finder/archive/JarArchive.java:
##########
@@ -41,22 +44,63 @@ public class JarArchive implements Archive, AutoCloseable {
private final JarFile jar;
private final MJarSupport mjar = new MJarSupport();
- public JarArchive(ClassLoader loader, URL url) {
+ /*
+ * Supports only 'file:/...' or 'jar:file:/...!/' URLs
+ */
+ public JarArchive(ClassLoader loader, URL url){
// if (!"jar".equals(url.getProtocol())) throw new
IllegalArgumentException("not a jar url: " + url);
- try {
- this.loader = loader;
- this.url = url;
- URL u = url;
+ this.loader = loader;
+ this.url = url;
+ File jarFile = null;
+ String jarPath;
+ int idx;
- String jarPath = url.getFile();
- if (jarPath.contains("!")) {
- jarPath = jarPath.substring(0, jarPath.indexOf("!"));
- u = new URL(jarPath);
+ // Wipe out 'jar:' prefix AND '!/{...}' suffix(if any)
+ if("jar".equalsIgnoreCase(url.getProtocol())){
+
+ try{
+ jarPath = url.getPath();
+ url = new URL(jarPath.substring(0, jarPath.lastIndexOf("!/")));
+ }catch(MalformedURLException ex){
+ // Probably CPU overheat and/or DRAM undervoltage
Review Comment:
yep but we don't want to get on main branch code with unexpected comments or
exception so I think it is important to not only care of the passing case but
more of error cases which are always the one costing the most ;)
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: dev-unsubscr...@geronimo.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
