[ 
https://issues.apache.org/jira/browse/GOBBLIN-1716?focusedWorklogId=812695&page=com.atlassian.jira.plugin.system.issuetabpanels:worklog-tabpanel#worklog-812695
 ]

ASF GitHub Bot logged work on GOBBLIN-1716:
-------------------------------------------

                Author: ASF GitHub Bot
            Created on: 28/Sep/22 00:04
            Start Date: 28/Sep/22 00:04
    Worklog Time Spent: 10m 
      Work Description: umustafi opened a new pull request, #3570:
URL: https://github.com/apache/gobblin/pull/3570

   * allow SpecStoreChangeMonitor to initialize partition and offsets
   * create unique group_id for each host's consumer client monitor
   
   Dear Gobblin maintainers,
   
   Please accept this PR. I understand that it will not be reviewed until I 
have checked off all the steps below!
   
   
   ### JIRA
   - [X] My PR addresses the following [Gobblin 
JIRA](https://issues.apache.org/jira/browse/GOBBLIN/) issues and references 
them in the PR title. For example, "[GOBBLIN-XXX] My Gobblin PR"
       - https://issues.apache.org/jira/browse/GOBBLIN-1716
   
   
   ### Description
   - [X] Here are some details about my PR, including screenshots (if 
applicable):
   Derived classes of HighLevelConsumer, for example SpecChangeMonitor, may 
want to initialize the kafka partitions and offset differently so we refactor 
the base class to grant this configurability. The default implementation 
remains the same as the original. 
   
   ### Tests
   - [X] My PR adds the following unit tests __OR__ does not need testing for 
this extremely good reason:
   
   
   ### Commits
   - [X] My commits all reference JIRA issues in their subject lines, and I 
have squashed multiple commits if they address the same issue. In addition, my 
commits follow the guidelines from "[How to write a good git commit 
message](http://chris.beams.io/posts/git-commit/)":
       1. Subject is separated from body by a blank line
       2. Subject is limited to 50 characters
       3. Subject does not end with a period
       4. Subject uses the imperative mood ("add", not "adding")
       5. Body wraps at 72 characters
       6. Body explains "what" and "why", not "how"
   
   




Issue Time Tracking
-------------------

            Worklog Id:     (was: 812695)
    Remaining Estimate: 0h
            Time Spent: 10m

> refactor HighLevelConsumer to make consumer initialization configurable
> -----------------------------------------------------------------------
>
>                 Key: GOBBLIN-1716
>                 URL: https://issues.apache.org/jira/browse/GOBBLIN-1716
>             Project: Apache Gobblin
>          Issue Type: Improvement
>            Reporter: Urmi Mustafi
>            Priority: Major
>          Time Spent: 10m
>  Remaining Estimate: 0h
>
> Derived classes of HighLevelConsumer, for example SpecChangeMonitor, may want 
> to initialize the kafka partitions and offset differently so we refactor the 
> base class to grant this configurability. The default implementation remains 
> the same as the original. 



--
This message was sent by Atlassian Jira
(v8.20.10#820010)

Reply via email to