[
https://issues.apache.org/jira/browse/GOBBLIN-1716?focusedWorklogId=812881&page=com.atlassian.jira.plugin.system.issuetabpanels:worklog-tabpanel#worklog-812881
]
ASF GitHub Bot logged work on GOBBLIN-1716:
-------------------------------------------
Author: ASF GitHub Bot
Created on: 28/Sep/22 12:38
Start Date: 28/Sep/22 12:38
Worklog Time Spent: 10m
Work Description: arjun4084346 commented on code in PR #3570:
URL: https://github.com/apache/gobblin/pull/3570#discussion_r982350774
##########
gobblin-service/src/main/java/org/apache/gobblin/service/monitoring/SpecStoreChangeMonitor.java:
##########
@@ -74,7 +76,16 @@ public String load(String key) throws Exception {
protected GobblinServiceJobScheduler scheduler;
public SpecStoreChangeMonitor(String topic, Config config, int numThreads) {
- super(topic, config, numThreads);
+ // Differentiate group id for each host
+ super(topic, config.withValue(GROUP_ID_KEY,
+ ConfigValueFactory.fromAnyRef(SPEC_STORE_CHANGE_MONITOR_PREFIX +
UUID.randomUUID().toString())),
+ numThreads);
+ initializeConsumerClient();
Review Comment:
the base class constructor is already calling this
Issue Time Tracking
-------------------
Worklog Id: (was: 812881)
Time Spent: 0.5h (was: 20m)
> refactor HighLevelConsumer to make consumer initialization configurable
> -----------------------------------------------------------------------
>
> Key: GOBBLIN-1716
> URL: https://issues.apache.org/jira/browse/GOBBLIN-1716
> Project: Apache Gobblin
> Issue Type: Improvement
> Reporter: Urmi Mustafi
> Priority: Major
> Time Spent: 0.5h
> Remaining Estimate: 0h
>
> Derived classes of HighLevelConsumer, for example SpecChangeMonitor, may want
> to initialize the kafka partitions and offset differently so we refactor the
> base class to grant this configurability. The default implementation remains
> the same as the original.
--
This message was sent by Atlassian Jira
(v8.20.10#820010)
