[
https://issues.apache.org/jira/browse/GOBBLIN-1716?focusedWorklogId=813168&page=com.atlassian.jira.plugin.system.issuetabpanels:worklog-tabpanel#worklog-813168
]
ASF GitHub Bot logged work on GOBBLIN-1716:
-------------------------------------------
Author: ASF GitHub Bot
Created on: 29/Sep/22 00:26
Start Date: 29/Sep/22 00:26
Worklog Time Spent: 10m
Work Description: umustafi commented on code in PR #3570:
URL: https://github.com/apache/gobblin/pull/3570#discussion_r982961629
##########
gobblin-modules/gobblin-kafka-common/src/main/java/org/apache/gobblin/kafka/client/GobblinKafkaConsumerClient.java:
##########
@@ -169,6 +169,8 @@ default long committed(KafkaPartition partition) {
public default void assignAndSeek(List<KafkaPartition> topicPartitions,
Map<KafkaPartition, LongWatermark> topicWatermarksMap) { return; }
+ public default void initializeClient(String topic) { return; }
Review Comment:
This method is what will contain the partition assignment and offset setting
logic to initialize the consumer. Since `SpecChangeMonitor` and
`HighLevelConsumer` expect the consumer to be a class with the interface of
`GobblinKafkaConsumerClient` there needs to be a method in this interface that
can be called to setup the client.
Issue Time Tracking
-------------------
Worklog Id: (was: 813168)
Time Spent: 50m (was: 40m)
> refactor HighLevelConsumer to make consumer initialization configurable
> -----------------------------------------------------------------------
>
> Key: GOBBLIN-1716
> URL: https://issues.apache.org/jira/browse/GOBBLIN-1716
> Project: Apache Gobblin
> Issue Type: Improvement
> Reporter: Urmi Mustafi
> Priority: Major
> Time Spent: 50m
> Remaining Estimate: 0h
>
> Derived classes of HighLevelConsumer, for example SpecChangeMonitor, may want
> to initialize the kafka partitions and offset differently so we refactor the
> base class to grant this configurability. The default implementation remains
> the same as the original.
--
This message was sent by Atlassian Jira
(v8.20.10#820010)
