[
https://issues.apache.org/jira/browse/GOBBLIN-1716?focusedWorklogId=813450&page=com.atlassian.jira.plugin.system.issuetabpanels:worklog-tabpanel#worklog-813450
]
ASF GitHub Bot logged work on GOBBLIN-1716:
-------------------------------------------
Author: ASF GitHub Bot
Created on: 29/Sep/22 18:58
Start Date: 29/Sep/22 18:58
Worklog Time Spent: 10m
Work Description: umustafi commented on code in PR #3570:
URL: https://github.com/apache/gobblin/pull/3570#discussion_r983919763
##########
gobblin-service/src/main/java/org/apache/gobblin/service/monitoring/SpecStoreChangeMonitor.java:
##########
@@ -74,7 +76,15 @@ public String load(String key) throws Exception {
protected GobblinServiceJobScheduler scheduler;
public SpecStoreChangeMonitor(String topic, Config config, int numThreads) {
- super(topic, config, numThreads);
+ // Differentiate group id for each host
+ super(topic, config.withValue(GROUP_ID_KEY,
+ ConfigValueFactory.fromAnyRef(SPEC_STORE_CHANGE_MONITOR_PREFIX +
UUID.randomUUID().toString())),
+ numThreads);
+ }
+
+ @Override
+ protected void initializeConsumerClient() {
Review Comment:
I can add that comment to explain it but it is difficult to move that logic
here as I need access to the underlying kafkaConsumer itself to get the
Partition Info for a particular kafka topic and then convert it to the list of
kafka partitions I need to set it to. Also after the `ConsumerClient` is
initialized the topic is still not set and would still require modifications to
the `GobblinKafkaConsumerClient` interface to extract partitions. That logic is
more easily managed in the consumer client itself.
Issue Time Tracking
-------------------
Worklog Id: (was: 813450)
Time Spent: 1h 10m (was: 1h)
> refactor HighLevelConsumer to make consumer initialization configurable
> -----------------------------------------------------------------------
>
> Key: GOBBLIN-1716
> URL: https://issues.apache.org/jira/browse/GOBBLIN-1716
> Project: Apache Gobblin
> Issue Type: Improvement
> Reporter: Urmi Mustafi
> Priority: Major
> Time Spent: 1h 10m
> Remaining Estimate: 0h
>
> Derived classes of HighLevelConsumer, for example SpecChangeMonitor, may want
> to initialize the kafka partitions and offset differently so we refactor the
> base class to grant this configurability. The default implementation remains
> the same as the original.
--
This message was sent by Atlassian Jira
(v8.20.10#820010)
