[
https://issues.apache.org/jira/browse/GOBBLIN-1716?focusedWorklogId=812698&page=com.atlassian.jira.plugin.system.issuetabpanels:worklog-tabpanel#worklog-812698
]
ASF GitHub Bot logged work on GOBBLIN-1716:
-------------------------------------------
Author: ASF GitHub Bot
Created on: 28/Sep/22 00:20
Start Date: 28/Sep/22 00:20
Worklog Time Spent: 10m
Work Description: codecov-commenter commented on PR #3570:
URL: https://github.com/apache/gobblin/pull/3570#issuecomment-1260231264
#
[Codecov](https://codecov.io/gh/apache/gobblin/pull/3570?src=pr&el=h1&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation)
Report
> Merging
[#3570](https://codecov.io/gh/apache/gobblin/pull/3570?src=pr&el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation)
(86edbbd) into
[master](https://codecov.io/gh/apache/gobblin/commit/31f7ec5b748f965426e2e99928d467f451b37b72?el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation)
(31f7ec5) will **increase** coverage by `3.94%`.
> The diff coverage is `0.00%`.
```diff
@@ Coverage Diff @@
## master #3570 +/- ##
============================================
+ Coverage 46.81% 50.75% +3.94%
+ Complexity 10566 5799 -4767
============================================
Files 2111 1061 -1050
Lines 82468 40264 -42204
Branches 9174 4507 -4667
============================================
- Hits 38607 20438 -18169
+ Misses 40301 18066 -22235
+ Partials 3560 1760 -1800
```
| [Impacted
Files](https://codecov.io/gh/apache/gobblin/pull/3570?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation)
| Coverage Δ | |
|---|---|---|
|
[...pache/gobblin/runtime/kafka/HighLevelConsumer.java](https://codecov.io/gh/apache/gobblin/pull/3570/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-Z29iYmxpbi1ydW50aW1lL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9nb2JibGluL3J1bnRpbWUva2Fma2EvSGlnaExldmVsQ29uc3VtZXIuamF2YQ==)
| `0.00% <0.00%> (ø)` | |
|
[...apache/gobblin/runtime/metrics/RuntimeMetrics.java](https://codecov.io/gh/apache/gobblin/pull/3570/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-Z29iYmxpbi1ydW50aW1lL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9nb2JibGluL3J1bnRpbWUvbWV0cmljcy9SdW50aW1lTWV0cmljcy5qYXZh)
| `0.00% <ø> (ø)` | |
|
[...lin/data/management/copy/iceberg/IcebergTable.java](https://codecov.io/gh/apache/gobblin/pull/3570/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-Z29iYmxpbi1kYXRhLW1hbmFnZW1lbnQvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2dvYmJsaW4vZGF0YS9tYW5hZ2VtZW50L2NvcHkvaWNlYmVyZy9JY2ViZXJnVGFibGUuamF2YQ==)
| `88.67% <0.00%> (-11.33%)` | :arrow_down: |
|
[...n/data/management/copy/iceberg/IcebergDataset.java](https://codecov.io/gh/apache/gobblin/pull/3570/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-Z29iYmxpbi1kYXRhLW1hbmFnZW1lbnQvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2dvYmJsaW4vZGF0YS9tYW5hZ2VtZW50L2NvcHkvaWNlYmVyZy9JY2ViZXJnRGF0YXNldC5qYXZh)
| `83.56% <0.00%> (-0.73%)` | :arrow_down: |
|
[...data/management/copy/RecursiveCopyableDataset.java](https://codecov.io/gh/apache/gobblin/pull/3570/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-Z29iYmxpbi1kYXRhLW1hbmFnZW1lbnQvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2dvYmJsaW4vZGF0YS9tYW5hZ2VtZW50L2NvcHkvUmVjdXJzaXZlQ29weWFibGVEYXRhc2V0LmphdmE=)
| `86.36% <0.00%> (ø)` | |
|
[...ta/management/copy/iceberg/IcebergHiveCatalog.java](https://codecov.io/gh/apache/gobblin/pull/3570/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-Z29iYmxpbi1kYXRhLW1hbmFnZW1lbnQvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2dvYmJsaW4vZGF0YS9tYW5hZ2VtZW50L2NvcHkvaWNlYmVyZy9JY2ViZXJnSGl2ZUNhdGFsb2cuamF2YQ==)
| `0.00% <0.00%> (ø)` | |
|
[...management/copy/iceberg/IcebergCatalogFactory.java](https://codecov.io/gh/apache/gobblin/pull/3570/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-Z29iYmxpbi1kYXRhLW1hbmFnZW1lbnQvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2dvYmJsaW4vZGF0YS9tYW5hZ2VtZW50L2NvcHkvaWNlYmVyZy9JY2ViZXJnQ2F0YWxvZ0ZhY3RvcnkuamF2YQ==)
| `0.00% <0.00%> (ø)` | |
|
[...anagement/copy/replication/ConfigBasedDataset.java](https://codecov.io/gh/apache/gobblin/pull/3570/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-Z29iYmxpbi1kYXRhLW1hbmFnZW1lbnQvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2dvYmJsaW4vZGF0YS9tYW5hZ2VtZW50L2NvcHkvcmVwbGljYXRpb24vQ29uZmlnQmFzZWREYXRhc2V0LmphdmE=)
| `68.87% <0.00%> (ø)` | |
|
[...bblin/kafka/client/GobblinKafkaConsumerClient.java](https://codecov.io/gh/apache/gobblin/pull/3570/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-Z29iYmxpbi1tb2R1bGVzL2dvYmJsaW4ta2Fma2EtY29tbW9uL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9nb2JibGluL2thZmthL2NsaWVudC9Hb2JibGluS2Fma2FDb25zdW1lckNsaWVudC5qYXZh)
| | |
|
[...lin/service/monitoring/SpecStoreChangeMonitor.java](https://codecov.io/gh/apache/gobblin/pull/3570/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-Z29iYmxpbi1zZXJ2aWNlL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9nb2JibGluL3NlcnZpY2UvbW9uaXRvcmluZy9TcGVjU3RvcmVDaGFuZ2VNb25pdG9yLmphdmE=)
| | |
| ... and [1064
more](https://codecov.io/gh/apache/gobblin/pull/3570/diff?src=pr&el=tree-more&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation)
| |
:mega: We’re building smart automated test selection to slash your CI/CD
build times. [Learn
more](https://about.codecov.io/iterative-testing/?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation)
Issue Time Tracking
-------------------
Worklog Id: (was: 812698)
Time Spent: 20m (was: 10m)
> refactor HighLevelConsumer to make consumer initialization configurable
> -----------------------------------------------------------------------
>
> Key: GOBBLIN-1716
> URL: https://issues.apache.org/jira/browse/GOBBLIN-1716
> Project: Apache Gobblin
> Issue Type: Improvement
> Reporter: Urmi Mustafi
> Priority: Major
> Time Spent: 20m
> Remaining Estimate: 0h
>
> Derived classes of HighLevelConsumer, for example SpecChangeMonitor, may want
> to initialize the kafka partitions and offset differently so we refactor the
> base class to grant this configurability. The default implementation remains
> the same as the original.
--
This message was sent by Atlassian Jira
(v8.20.10#820010)
