[
https://issues.apache.org/jira/browse/GOBBLIN-1811?focusedWorklogId=856565&page=com.atlassian.jira.plugin.system.issuetabpanels:worklog-tabpanel#worklog-856565
]
ASF GitHub Bot logged work on GOBBLIN-1811:
-------------------------------------------
Author: ASF GitHub Bot
Created on: 12/Apr/23 20:23
Start Date: 12/Apr/23 20:23
Worklog Time Spent: 10m
Work Description: meethngala commented on code in PR #3673:
URL: https://github.com/apache/gobblin/pull/3673#discussion_r1164612967
##########
gobblin-data-management/src/main/java/org/apache/gobblin/data/management/copy/iceberg/IcebergDatasetFinder.java:
##########
@@ -88,7 +92,7 @@ public List<IcebergDataset> findDatasets() throws IOException
{
IcebergCatalog sourceIcebergCatalog =
createIcebergCatalog(this.properties, CatalogLocation.SOURCE);
IcebergCatalog destinationIcebergCatalog =
createIcebergCatalog(this.properties, CatalogLocation.DESTINATION);
/* Each Iceberg dataset maps to an Iceberg table */
- matchingDatasets.add(createIcebergDataset(dbName, tblName,
sourceIcebergCatalog, destinationIcebergCatalog, properties, sourceFs));
+ matchingDatasets.add(createIcebergDataset(dbName, tblName,
sourceIcebergCatalog, destinationIcebergCatalog, this.properties, sourceFs));
Review Comment:
I don't see why it shouldn't be specific to the instance of the class. I'll
update it in my latest commit!
Issue Time Tracking
-------------------
Worklog Id: (was: 856565)
Time Spent: 1h 10m (was: 1h)
> Fix Iceberg Registration Serialization
> --------------------------------------
>
> Key: GOBBLIN-1811
> URL: https://issues.apache.org/jira/browse/GOBBLIN-1811
> Project: Apache Gobblin
> Issue Type: New Feature
> Reporter: Meeth Gala
> Priority: Major
> Time Spent: 1h 10m
> Remaining Estimate: 0h
>
--
This message was sent by Atlassian Jira
(v8.20.10#820010)
