[ 
https://issues.apache.org/jira/browse/GOBBLIN-1811?focusedWorklogId=856936&page=com.atlassian.jira.plugin.system.issuetabpanels:worklog-tabpanel#worklog-856936
 ]

ASF GitHub Bot logged work on GOBBLIN-1811:
-------------------------------------------

                Author: ASF GitHub Bot
            Created on: 13/Apr/23 23:12
            Start Date: 13/Apr/23 23:12
    Worklog Time Spent: 10m 
      Work Description: autumnust commented on code in PR #3673:
URL: https://github.com/apache/gobblin/pull/3673#discussion_r1166116386


##########
gobblin-data-management/src/main/java/org/apache/gobblin/data/management/copy/iceberg/IcebergTable.java:
##########
@@ -198,7 +198,8 @@ protected DatasetDescriptor getDatasetDescriptor(FileSystem 
fs) {
    * @param dstMetadata is null if destination {@link IcebergTable} is absent, 
in which case registration is skipped */
   protected void registerIcebergTable(TableMetadata srcMetadata, TableMetadata 
dstMetadata) {
     if (dstMetadata != null) {

Review Comment:
   ok i guess your method javadoc explains





Issue Time Tracking
-------------------

    Worklog Id:     (was: 856936)
    Time Spent: 2.5h  (was: 2h 20m)

> Fix Iceberg Registration Serialization
> --------------------------------------
>
>                 Key: GOBBLIN-1811
>                 URL: https://issues.apache.org/jira/browse/GOBBLIN-1811
>             Project: Apache Gobblin
>          Issue Type: New Feature
>            Reporter: Meeth Gala
>            Priority: Major
>          Time Spent: 2.5h
>  Remaining Estimate: 0h
>




--
This message was sent by Atlassian Jira
(v8.20.10#820010)

Reply via email to