[ 
https://issues.apache.org/jira/browse/GOBBLIN-1811?focusedWorklogId=856931&page=com.atlassian.jira.plugin.system.issuetabpanels:worklog-tabpanel#worklog-856931
 ]

ASF GitHub Bot logged work on GOBBLIN-1811:
-------------------------------------------

                Author: ASF GitHub Bot
            Created on: 13/Apr/23 22:34
            Start Date: 13/Apr/23 22:34
    Worklog Time Spent: 10m 
      Work Description: meethngala commented on code in PR #3673:
URL: https://github.com/apache/gobblin/pull/3673#discussion_r1166089729


##########
gobblin-data-management/src/main/java/org/apache/gobblin/data/management/copy/iceberg/IcebergDataset.java:
##########
@@ -316,8 +316,8 @@ protected DatasetDescriptor 
getDestinationDataset(FileSystem targetFs) {
     return this.destIcebergTable.getDatasetDescriptor(targetFs);
   }
 
-  private PostPublishStep createPostPublishStep(IcebergTable srcIcebergTable, 
IcebergTable dstIcebergTable) {
-    IcebergRegisterStep icebergRegisterStep = new 
IcebergRegisterStep(srcIcebergTable, dstIcebergTable);
+  private PostPublishStep createPostPublishStep(String dbName, String 
inputTableName, Properties properties) {

Review Comment:
   Added the TODO as suggested above in my latest commit!





Issue Time Tracking
-------------------

    Worklog Id:     (was: 856931)
    Time Spent: 2h  (was: 1h 50m)

> Fix Iceberg Registration Serialization
> --------------------------------------
>
>                 Key: GOBBLIN-1811
>                 URL: https://issues.apache.org/jira/browse/GOBBLIN-1811
>             Project: Apache Gobblin
>          Issue Type: New Feature
>            Reporter: Meeth Gala
>            Priority: Major
>          Time Spent: 2h
>  Remaining Estimate: 0h
>




--
This message was sent by Atlassian Jira
(v8.20.10#820010)

Reply via email to