[
https://issues.apache.org/jira/browse/GOBBLIN-1811?focusedWorklogId=856577&page=com.atlassian.jira.plugin.system.issuetabpanels:worklog-tabpanel#worklog-856577
]
ASF GitHub Bot logged work on GOBBLIN-1811:
-------------------------------------------
Author: ASF GitHub Bot
Created on: 12/Apr/23 21:25
Start Date: 12/Apr/23 21:25
Worklog Time Spent: 10m
Work Description: phet commented on code in PR #3673:
URL: https://github.com/apache/gobblin/pull/3673#discussion_r1164668823
##########
gobblin-data-management/src/main/java/org/apache/gobblin/data/management/copy/iceberg/IcebergDataset.java:
##########
@@ -316,8 +316,8 @@ protected DatasetDescriptor
getDestinationDataset(FileSystem targetFs) {
return this.destIcebergTable.getDatasetDescriptor(targetFs);
}
- private PostPublishStep createPostPublishStep(IcebergTable srcIcebergTable,
IcebergTable dstIcebergTable) {
- IcebergRegisterStep icebergRegisterStep = new
IcebergRegisterStep(srcIcebergTable, dstIcebergTable);
+ private PostPublishStep createPostPublishStep(String dbName, String
inputTableName, Properties properties) {
Review Comment:
ah yes, I see the challenge arising from the hadoop props. these are likely
to have a predictable prefix too, so we could retain only specific ones... but
that might take trial-an-error, so, for now, I suggest adding a TODO
documenting our preference not to serialize absolutely every prop... and yet
the challenge w/ the hadoop config.
as we return to this, we should also investigate whether `Configuration` may
itself already be serializable
Issue Time Tracking
-------------------
Worklog Id: (was: 856577)
Time Spent: 1h 50m (was: 1h 40m)
> Fix Iceberg Registration Serialization
> --------------------------------------
>
> Key: GOBBLIN-1811
> URL: https://issues.apache.org/jira/browse/GOBBLIN-1811
> Project: Apache Gobblin
> Issue Type: New Feature
> Reporter: Meeth Gala
> Priority: Major
> Time Spent: 1h 50m
> Remaining Estimate: 0h
>
--
This message was sent by Atlassian Jira
(v8.20.10#820010)
