[
https://issues.apache.org/jira/browse/GOBBLIN-1811?focusedWorklogId=856935&page=com.atlassian.jira.plugin.system.issuetabpanels:worklog-tabpanel#worklog-856935
]
ASF GitHub Bot logged work on GOBBLIN-1811:
-------------------------------------------
Author: ASF GitHub Bot
Created on: 13/Apr/23 22:58
Start Date: 13/Apr/23 22:58
Worklog Time Spent: 10m
Work Description: autumnust commented on code in PR #3673:
URL: https://github.com/apache/gobblin/pull/3673#discussion_r1166102102
##########
gobblin-data-management/src/main/java/org/apache/gobblin/data/management/copy/iceberg/IcebergTable.java:
##########
@@ -198,7 +198,8 @@ protected DatasetDescriptor getDatasetDescriptor(FileSystem
fs) {
* @param dstMetadata is null if destination {@link IcebergTable} is absent,
in which case registration is skipped */
protected void registerIcebergTable(TableMetadata srcMetadata, TableMetadata
dstMetadata) {
if (dstMetadata != null) {
Review Comment:
are we assuming that `dstMetadata` could never be null ?
Issue Time Tracking
-------------------
Worklog Id: (was: 856935)
Time Spent: 2h 20m (was: 2h 10m)
> Fix Iceberg Registration Serialization
> --------------------------------------
>
> Key: GOBBLIN-1811
> URL: https://issues.apache.org/jira/browse/GOBBLIN-1811
> Project: Apache Gobblin
> Issue Type: New Feature
> Reporter: Meeth Gala
> Priority: Major
> Time Spent: 2h 20m
> Remaining Estimate: 0h
>
--
This message was sent by Atlassian Jira
(v8.20.10#820010)
