[ 
https://issues.apache.org/jira/browse/GOBBLIN-1846?focusedWorklogId=866585&page=com.atlassian.jira.plugin.system.issuetabpanels:worklog-tabpanel#worklog-866585
 ]

ASF GitHub Bot logged work on GOBBLIN-1846:
-------------------------------------------

                Author: ASF GitHub Bot
            Created on: 20/Jun/23 23:25
            Start Date: 20/Jun/23 23:25
    Worklog Time Spent: 10m 
      Work Description: umustafi opened a new pull request, #3707:
URL: https://github.com/apache/gobblin/pull/3707

   * Adds logging at 3 critical points to ensure no scheduled events are missed
        - when jobs are first rescheduled (or updated)
        - each trigger of a new job
        - when jobs are unscheduled
   
   Dear Gobblin maintainers,
   
   Please accept this PR. I understand that it will not be reviewed until I 
have checked off all the steps below!
   
   
   ### JIRA
   - [X] My PR addresses the following [Gobblin 
JIRA](https://issues.apache.org/jira/browse/GOBBLIN/) issues and references 
them in the PR title. For example, "[GOBBLIN-XXX] My Gobblin PR"
       - https://issues.apache.org/jira/browse/GOBBLIN-1846
   
   
   ### Description
   - [X] Here are some details about my PR, including screenshots (if 
applicable):
   Follow up to previous PR 
[GOBBLIN-1837](https://github.com/apache/gobblin/pull/3700) to add validation 
via logging statements that we will query to ensure no scheduled trigger events 
are missed during host downtime. 
   
   ### Tests
   - [X] My PR adds the following unit tests __OR__ does not need testing for 
this extremely good reason:
   N/A to be added in the future but will be validated using these statements 
and local deploy
   
   ### Commits
   - [X] My commits all reference JIRA issues in their subject lines, and I 
have squashed multiple commits if they address the same issue. In addition, my 
commits follow the guidelines from "[How to write a good git commit 
message](http://chris.beams.io/posts/git-commit/)":
       1. Subject is separated from body by a blank line
       2. Subject is limited to 50 characters
       3. Subject does not end with a period
       4. Subject uses the imperative mood ("add", not "adding")
       5. Body wraps at 72 characters
       6. Body explains "what" and "why", not "how"
   
   




Issue Time Tracking
-------------------

            Worklog Id:     (was: 866585)
    Remaining Estimate: 0h
            Time Spent: 10m

> Add logs to validate scheduled job triggers
> -------------------------------------------
>
>                 Key: GOBBLIN-1846
>                 URL: https://issues.apache.org/jira/browse/GOBBLIN-1846
>             Project: Apache Gobblin
>          Issue Type: Bug
>          Components: gobblin-service
>            Reporter: Urmi Mustafi
>            Assignee: Abhishek Tiwari
>            Priority: Major
>          Time Spent: 10m
>  Remaining Estimate: 0h
>
> Add logging in 3 critical places: newly scheduled jobs (or updated ones), 
> each trigger of a new job, and when jobs are unscheduled so we can track 
> every expected trigger of a scheduled job occurs. We will use the three types 
> of logs mentioned to ensure there are no missed scheduling events due to host 
> downtime with a simple analysis of the logs. 



--
This message was sent by Atlassian Jira
(v8.20.10#820010)

Reply via email to