[
https://issues.apache.org/jira/browse/GOBBLIN-1846?focusedWorklogId=866858&page=com.atlassian.jira.plugin.system.issuetabpanels:worklog-tabpanel#worklog-866858
]
ASF GitHub Bot logged work on GOBBLIN-1846:
-------------------------------------------
Author: ASF GitHub Bot
Created on: 22/Jun/23 01:19
Start Date: 22/Jun/23 01:19
Worklog Time Spent: 10m
Work Description: phet commented on code in PR #3707:
URL: https://github.com/apache/gobblin/pull/3707#discussion_r1237876810
##########
gobblin-service/src/main/java/org/apache/gobblin/service/modules/scheduler/GobblinServiceJobScheduler.java:
##########
@@ -591,9 +596,7 @@ private void unscheduleSpec(URI specURI, String
specVersion) throws JobException
try {
FlowSpec spec = (FlowSpec) this.flowCatalog.get().getSpecs(specURI);
Properties properties = spec.getConfigAsProperties();
- _log.info("Scheduler trigger tracing: [flowName: {} flowGroup: {}] -
Unscheduled Spec",
- properties.getProperty(ConfigurationKeys.JOB_NAME_KEY),
- properties.getProperty(ConfigurationKeys.JOB_GROUP_KEY));
+ _log.info(jobSchedulerTracePrefixBuilder(properties) + "Unscheduled
Spec");
Review Comment:
I definitely support the reuse between these... but also see the prefix
builder using `FLOW_GROUP_KEY`, while the prior revision had used
`JOB_GROUP_KEY`. can the former stand in for the latter... or was it incorrect
previously to use `JOB_GROUP_KEY`?
Issue Time Tracking
-------------------
Worklog Id: (was: 866858)
Time Spent: 1h 20m (was: 1h 10m)
> Add logs to validate scheduled job triggers
> -------------------------------------------
>
> Key: GOBBLIN-1846
> URL: https://issues.apache.org/jira/browse/GOBBLIN-1846
> Project: Apache Gobblin
> Issue Type: Bug
> Components: gobblin-service
> Reporter: Urmi Mustafi
> Assignee: Abhishek Tiwari
> Priority: Major
> Time Spent: 1h 20m
> Remaining Estimate: 0h
>
> Add logging in 3 critical places: newly scheduled jobs (or updated ones),
> each trigger of a new job, and when jobs are unscheduled so we can track
> every expected trigger of a scheduled job occurs. We will use the three types
> of logs mentioned to ensure there are no missed scheduling events due to host
> downtime with a simple analysis of the logs.
--
This message was sent by Atlassian Jira
(v8.20.10#820010)
