[
https://issues.apache.org/jira/browse/GOBBLIN-1846?focusedWorklogId=866591&page=com.atlassian.jira.plugin.system.issuetabpanels:worklog-tabpanel#worklog-866591
]
ASF GitHub Bot logged work on GOBBLIN-1846:
-------------------------------------------
Author: ASF GitHub Bot
Created on: 21/Jun/23 01:01
Start Date: 21/Jun/23 01:01
Worklog Time Spent: 10m
Work Description: Will-Lo commented on code in PR #3707:
URL: https://github.com/apache/gobblin/pull/3707#discussion_r1236131987
##########
gobblin-runtime/src/main/java/org/apache/gobblin/scheduler/JobScheduler.java:
##########
@@ -398,7 +398,8 @@ public void scheduleJob(Properties jobProps, JobListener
jobListener, Map<String
// Schedule the Quartz job with a trigger built from the job
configuration
Trigger trigger = createTriggerForJob(job.getKey(), jobProps);
this.scheduler.getScheduler().scheduleJob(job, trigger);
- LOG.info(String.format("Scheduled job %s. Next run: %s.", job.getKey(),
trigger.getNextFireTime()));
+ LOG.info("Scheduler trigger validation: [flowName: {} flowGroup: {}] -
nextTriggerTime: {} - "
+ + "Job scheduled", job.getKey().getName(), job.getKey().getGroup(),
trigger.getNextFireTime());
Review Comment:
I don't think it's guaranteed that a job here has a flowName and flowGroup
since this is the generic jobScheduler class. Also, the jobName and jobGroup is
not necessarily the flowName and flowGroup either.
##########
gobblin-runtime/src/main/java/org/apache/gobblin/scheduler/JobScheduler.java:
##########
@@ -612,7 +613,10 @@ public void executeImpl(JobExecutionContext context)
long triggerTimestampMillis = trigger.getPreviousFireTime().getTime();
jobProps.setProperty(ConfigurationKeys.SCHEDULER_EVENT_TO_TRIGGER_TIMESTAMP_MILLIS_KEY,
String.valueOf(triggerTimestampMillis));
-
+ LOG.info("Scheduler trigger validation: [flowName: {} flowGroup: {}] -
triggerTime: {} nextTriggerTime: {} - "
+ + "Job triggered by scheduler",
Review Comment:
Same comment here, the job name and job group don't map to flownames and
flowgroups exactly.
If you want to make it GaaS Specific, it has to live in the
`GobblinServiceJobScheduler`
Issue Time Tracking
-------------------
Worklog Id: (was: 866591)
Time Spent: 40m (was: 0.5h)
> Add logs to validate scheduled job triggers
> -------------------------------------------
>
> Key: GOBBLIN-1846
> URL: https://issues.apache.org/jira/browse/GOBBLIN-1846
> Project: Apache Gobblin
> Issue Type: Bug
> Components: gobblin-service
> Reporter: Urmi Mustafi
> Assignee: Abhishek Tiwari
> Priority: Major
> Time Spent: 40m
> Remaining Estimate: 0h
>
> Add logging in 3 critical places: newly scheduled jobs (or updated ones),
> each trigger of a new job, and when jobs are unscheduled so we can track
> every expected trigger of a scheduled job occurs. We will use the three types
> of logs mentioned to ensure there are no missed scheduling events due to host
> downtime with a simple analysis of the logs.
--
This message was sent by Atlassian Jira
(v8.20.10#820010)
