[
https://issues.apache.org/jira/browse/GOBBLIN-1846?focusedWorklogId=866598&page=com.atlassian.jira.plugin.system.issuetabpanels:worklog-tabpanel#worklog-866598
]
ASF GitHub Bot logged work on GOBBLIN-1846:
-------------------------------------------
Author: ASF GitHub Bot
Created on: 21/Jun/23 02:30
Start Date: 21/Jun/23 02:30
Worklog Time Spent: 10m
Work Description: umustafi commented on code in PR #3707:
URL: https://github.com/apache/gobblin/pull/3707#discussion_r1236207362
##########
gobblin-runtime/src/main/java/org/apache/gobblin/scheduler/JobScheduler.java:
##########
@@ -612,7 +613,10 @@ public void executeImpl(JobExecutionContext context)
long triggerTimestampMillis = trigger.getPreviousFireTime().getTime();
jobProps.setProperty(ConfigurationKeys.SCHEDULER_EVENT_TO_TRIGGER_TIMESTAMP_MILLIS_KEY,
String.valueOf(triggerTimestampMillis));
-
+ LOG.info("Scheduler trigger validation: [flowName: {} flowGroup: {}] -
triggerTime: {} nextTriggerTime: {} - "
+ + "Job triggered by scheduler",
Review Comment:
I'll update the first comment to say newly scheduled, but this second
instance is not re-scheduled but rather the callback invoked when the Scheduler
trigger fires and the job is actually run. This is the important part we want
to validate. However, I may need to override the super class method by the
`GobblinServiceJobScheduler` to retrieve the flow properties.
Issue Time Tracking
-------------------
Worklog Id: (was: 866598)
Time Spent: 50m (was: 40m)
> Add logs to validate scheduled job triggers
> -------------------------------------------
>
> Key: GOBBLIN-1846
> URL: https://issues.apache.org/jira/browse/GOBBLIN-1846
> Project: Apache Gobblin
> Issue Type: Bug
> Components: gobblin-service
> Reporter: Urmi Mustafi
> Assignee: Abhishek Tiwari
> Priority: Major
> Time Spent: 50m
> Remaining Estimate: 0h
>
> Add logging in 3 critical places: newly scheduled jobs (or updated ones),
> each trigger of a new job, and when jobs are unscheduled so we can track
> every expected trigger of a scheduled job occurs. We will use the three types
> of logs mentioned to ensure there are no missed scheduling events due to host
> downtime with a simple analysis of the logs.
--
This message was sent by Atlassian Jira
(v8.20.10#820010)
