[
https://issues.apache.org/jira/browse/GOBBLIN-1846?focusedWorklogId=866820&page=com.atlassian.jira.plugin.system.issuetabpanels:worklog-tabpanel#worklog-866820
]
ASF GitHub Bot logged work on GOBBLIN-1846:
-------------------------------------------
Author: ASF GitHub Bot
Created on: 21/Jun/23 19:12
Start Date: 21/Jun/23 19:12
Worklog Time Spent: 10m
Work Description: umustafi commented on code in PR #3707:
URL: https://github.com/apache/gobblin/pull/3707#discussion_r1237537547
##########
gobblin-runtime/src/main/java/org/apache/gobblin/scheduler/JobScheduler.java:
##########
@@ -398,7 +398,8 @@ public void scheduleJob(Properties jobProps, JobListener
jobListener, Map<String
// Schedule the Quartz job with a trigger built from the job
configuration
Trigger trigger = createTriggerForJob(job.getKey(), jobProps);
this.scheduler.getScheduler().scheduleJob(job, trigger);
- LOG.info(String.format("Scheduled job %s. Next run: %s.", job.getKey(),
trigger.getNextFireTime()));
+ LOG.info("Scheduler trigger validation: [flowName: {} flowGroup: {}] -
nextTriggerTime: {} - "
+ + "Job scheduled", job.getKey().getName(), job.getKey().getGroup(),
trigger.getNextFireTime());
Review Comment:
Good pt, there should be two different log lines printed for `JobScheduler`
and `GobblinServiceJobScheduler`. Both contain job name and group, but only the
latter will have the flow name and flow group. I created a util that will be
overridden by the `GobblinServiceJobScheduler` class to extract the flow
information for the tracing log line.
Issue Time Tracking
-------------------
Worklog Id: (was: 866820)
Time Spent: 1h (was: 50m)
> Add logs to validate scheduled job triggers
> -------------------------------------------
>
> Key: GOBBLIN-1846
> URL: https://issues.apache.org/jira/browse/GOBBLIN-1846
> Project: Apache Gobblin
> Issue Type: Bug
> Components: gobblin-service
> Reporter: Urmi Mustafi
> Assignee: Abhishek Tiwari
> Priority: Major
> Time Spent: 1h
> Remaining Estimate: 0h
>
> Add logging in 3 critical places: newly scheduled jobs (or updated ones),
> each trigger of a new job, and when jobs are unscheduled so we can track
> every expected trigger of a scheduled job occurs. We will use the three types
> of logs mentioned to ensure there are no missed scheduling events due to host
> downtime with a simple analysis of the logs.
--
This message was sent by Atlassian Jira
(v8.20.10#820010)
