umustafi commented on code in PR #3746:
URL: https://github.com/apache/gobblin/pull/3746#discussion_r1298745894
##########
gobblin-service/src/main/java/org/apache/gobblin/service/modules/orchestration/DagManager.java:
##########
@@ -504,12 +505,15 @@ public void
handleLaunchFlowEvent(DagActionStore.DagAction action) {
if (optionalJobExecutionPlanDag.isPresent()) {
addDag(optionalJobExecutionPlanDag.get(), true, true);
}
+ // Upon handling the action, delete it so on leadership change this is
not duplicated
+ this.dagActionStore.get().deleteDagAction(action);
Review Comment:
Yes, for now the subsequent leader will add the same dag again. We have at
least once guarantee with executions so this is pretty tolerable for now imo.
The issue arises when service is overloaded and keeps dying for some reason
before deletion. In average case, we won't really have too many dags with
multiple execution if we also have retention running on this table.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
