phet commented on code in PR #3746:
URL: https://github.com/apache/gobblin/pull/3746#discussion_r1298832738
##########
gobblin-service/src/main/java/org/apache/gobblin/service/modules/orchestration/DagManager.java:
##########
@@ -504,12 +505,15 @@ public void
handleLaunchFlowEvent(DagActionStore.DagAction action) {
if (optionalJobExecutionPlanDag.isPresent()) {
addDag(optionalJobExecutionPlanDag.get(), true, true);
}
+ // Upon handling the action, delete it so on leadership change this is
not duplicated
+ this.dagActionStore.get().deleteDagAction(action);
Review Comment:
I wouldn't expect more than the *highly infrequent* failure between `addDag`
and execution of that very next line. and even then wouldn't it be at most one
DAG getting duplicated per service restart (so VERY SLOW growth)?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
