umustafi commented on code in PR #3746:
URL: https://github.com/apache/gobblin/pull/3746#discussion_r1298747827
##########
gobblin-service/src/main/java/org/apache/gobblin/service/modules/orchestration/DagManager.java:
##########
@@ -504,12 +505,15 @@ public void
handleLaunchFlowEvent(DagActionStore.DagAction action) {
if (optionalJobExecutionPlanDag.isPresent()) {
addDag(optionalJobExecutionPlanDag.get(), true, true);
}
+ // Upon handling the action, delete it so on leadership change this is
not duplicated
+ this.dagActionStore.get().deleteDagAction(action);
Review Comment:
We can plan a refactor to save the compilation of the dag in mysql so we can
de-dup dags with the same plan id and avoid this problem down the road. Right
now we have "at least once" guarantee, this will allow "exactly once" which is
more desirable but not immediately necessary.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
