umustafi commented on code in PR #3746:
URL: https://github.com/apache/gobblin/pull/3746#discussion_r1298970984
##########
gobblin-service/src/main/java/org/apache/gobblin/service/modules/orchestration/DagManager.java:
##########
@@ -504,12 +505,15 @@ public void
handleLaunchFlowEvent(DagActionStore.DagAction action) {
if (optionalJobExecutionPlanDag.isPresent()) {
addDag(optionalJobExecutionPlanDag.get(), true, true);
}
Review Comment:
the method `FlowCompilationValidationHelper.createExecutionPlanIfValid` does
all the necessary checks -> whether or not it can compile, if there's an
ongoing execution and concurrent executions are allowed, and that the plan is
not null/empty. If any of the failure conditions are met, the return value is
`Optional.absent()`
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
