phet commented on code in PR #3746:
URL: https://github.com/apache/gobblin/pull/3746#discussion_r1298829396
##########
gobblin-service/src/main/java/org/apache/gobblin/service/modules/orchestration/DagManager.java:
##########
@@ -504,12 +505,15 @@ public void
handleLaunchFlowEvent(DagActionStore.DagAction action) {
if (optionalJobExecutionPlanDag.isPresent()) {
addDag(optionalJobExecutionPlanDag.get(), true, true);
}
Review Comment:
sorry that I'm forgetting... where do we log/handle the case of no exec plan
because the `FlowSpec` was invalid? is that done by the caller?
##########
gobblin-service/src/main/java/org/apache/gobblin/service/modules/orchestration/DagManager.java:
##########
@@ -494,6 +494,7 @@ public synchronized void setActive(boolean active) {
* the process.
*/
public void handleLaunchFlowEvent(DagActionStore.DagAction action) {
+ log.info("Handle launch flow event for action {}", action);
FlowId flowId = action.getFlowId();
FlowSpec spec;
Review Comment:
can't `spec` be scoped entirely within the `try` block?
##########
gobblin-service/src/main/java/org/apache/gobblin/service/modules/orchestration/DagManager.java:
##########
@@ -494,6 +494,7 @@ public synchronized void setActive(boolean active) {
* the process.
*/
public void handleLaunchFlowEvent(DagActionStore.DagAction action) {
+ log.info("Handle launch flow event for action {}", action);
Review Comment:
add `Preconditions` to verify this is in fact a LAUNCH action?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
