[
https://issues.apache.org/jira/browse/GOBBLIN-1996?focusedWorklogId=902916&page=com.atlassian.jira.plugin.system.issuetabpanels:worklog-tabpanel#worklog-902916
]
ASF GitHub Bot logged work on GOBBLIN-1996:
-------------------------------------------
Author: ASF GitHub Bot
Created on: 31/Jan/24 22:14
Start Date: 31/Jan/24 22:14
Worklog Time Spent: 10m
Work Description: homatthew commented on code in PR #3865:
URL: https://github.com/apache/gobblin/pull/3865#discussion_r1473531890
##########
gobblin-runtime/src/main/java/org/apache/gobblin/runtime/app/ServiceBasedAppLauncher.java:
##########
@@ -163,9 +170,17 @@ public void run() {
});
LOG.info("Starting the Gobblin application and all its associated
Services");
+ for (Service service : this.services) {
+ LOG.info("Starting service " + service.getClass().getSimpleName());
+ }
// Start the application
- this.serviceManager.startAsync().awaitHealthy();
+ try {
+
this.serviceManager.startAsync().awaitHealthy(startupTimeout.getSeconds(),
TimeUnit.SECONDS);
Review Comment:
In this case, `startAsync` is not really working as expected when using the
FSConfigurationManager. The actual work being done in cluster is done via the
`FSConfigurationManager` when that class takes that config and produces a
source out of the `.conf` file.
The `awaitHealthy` call here waits indefinitely and suspends this current
thread in the current implementation. It does not impede our ability to
fail-fast because often just hangs if there's an issue. If anything, we can
fail faster because a configurable timeout allows us to unblock this thread and
trigger the `shutdown` when the `Workflow` finishes (successfully or
unsuccessfully)
Issue Time Tracking
-------------------
Worklog Id: (was: 902916)
Time Spent: 2h (was: 1h 50m)
> Add ability for Yarn app to terminate on finishing of temporal flow
> -------------------------------------------------------------------
>
> Key: GOBBLIN-1996
> URL: https://issues.apache.org/jira/browse/GOBBLIN-1996
> Project: Apache Gobblin
> Issue Type: Improvement
> Reporter: Matthew Ho
> Priority: Major
> Time Spent: 2h
> Remaining Estimate: 0h
>
--
This message was sent by Atlassian Jira
(v8.20.10#820010)