[
https://issues.apache.org/jira/browse/GOBBLIN-2014?focusedWorklogId=909516&page=com.atlassian.jira.plugin.system.issuetabpanels:worklog-tabpanel#worklog-909516
]
ASF GitHub Bot logged work on GOBBLIN-2014:
-------------------------------------------
Author: ASF GitHub Bot
Created on: 12/Mar/24 22:23
Start Date: 12/Mar/24 22:23
Worklog Time Spent: 10m
Work Description: phet commented on code in PR #3894:
URL: https://github.com/apache/gobblin/pull/3894#discussion_r1522186988
##########
gobblin-temporal/src/main/java/org/apache/gobblin/temporal/workflows/metrics/EventSubmitterContext.java:
##########
@@ -79,6 +73,76 @@ private static Class resolveClass(String canonicalClassName)
{
} catch (ClassNotFoundException e) {
throw new RuntimeException(e);
}
+ }
+
+ @AllArgsConstructor
+ @NoArgsConstructor
+ public static class Builder {
+ private List<Tag<?>> tags = new ArrayList<>();
+ private String namespace;
+ public Builder(EventSubmitter eventSubmitter) {
+ this.tags.addAll(eventSubmitter.getTags());
+ this.namespace = eventSubmitter.getNamespace();
+ }
+ public Builder addTag(Tag<?> tag) {
Review Comment:
ctor needs a blank line before and after
##########
gobblin-temporal/src/main/java/org/apache/gobblin/temporal/workflows/metrics/EventSubmitterContext.java:
##########
@@ -17,18 +17,26 @@
package org.apache.gobblin.temporal.workflows.metrics;
+import com.google.common.collect.ImmutableList;
+import java.util.ArrayList;
Review Comment:
import order
Issue Time Tracking
-------------------
Worklog Id: (was: 909516)
Time Spent: 3h (was: 2h 50m)
> Add metadata tags for events sent from Temporal to be parseable in GaaS
> -----------------------------------------------------------------------
>
> Key: GOBBLIN-2014
> URL: https://issues.apache.org/jira/browse/GOBBLIN-2014
> Project: Apache Gobblin
> Issue Type: Bug
> Components: gobblin-service
> Reporter: William Lo
> Assignee: Abhishek Tiwari
> Priority: Major
> Time Spent: 3h
> Remaining Estimate: 0h
>
> Gobblin's Temporal workflow launches through `ExecuteGobblinJobLauncher`, but
> the eventSubmitter created in that class does not have the necessary metadata
> needed in order to send events to GaaS.
> We want to populate the additional tags to read from the job props that
> contain the information needed for these events to be readable from GaaS.
--
This message was sent by Atlassian Jira
(v8.20.10#820010)
