[ 
https://issues.apache.org/jira/browse/GOBBLIN-2014?focusedWorklogId=909512&page=com.atlassian.jira.plugin.system.issuetabpanels:worklog-tabpanel#worklog-909512
 ]

ASF GitHub Bot logged work on GOBBLIN-2014:
-------------------------------------------

                Author: ASF GitHub Bot
            Created on: 12/Mar/24 21:44
            Start Date: 12/Mar/24 21:44
    Worklog Time Spent: 10m 
      Work Description: Will-Lo commented on code in PR #3894:
URL: https://github.com/apache/gobblin/pull/3894#discussion_r1522153143


##########
gobblin-temporal/src/main/java/org/apache/gobblin/temporal/ddm/launcher/ProcessWorkUnitsJobLauncher.java:
##########
@@ -85,7 +85,9 @@ public void submitJob(List<WorkUnit> workunits) {
       URI nameNodeUri = new URI(PropertiesUtils.getRequiredProp(this.jobProps, 
GOBBLIN_TEMPORAL_JOB_LAUNCHER_ARG_NAME_NODE_URI));
       // NOTE: `Path` is challenging for temporal to ser/de, but nonetheless 
do pre-construct as `Path`, to pre-validate this prop string's contents
       Path workUnitsDir = new 
Path(PropertiesUtils.getRequiredProp(this.jobProps, 
GOBBLIN_TEMPORAL_JOB_LAUNCHER_ARG_WORK_UNITS_DIR));
-      EventSubmitterContext eventSubmitterContext = new 
EventSubmitterContext(this.eventSubmitter);
+      EventSubmitterContext eventSubmitterContext = new 
EventSubmitterContext.Builder()
+          .withEventSubmitter(eventSubmitter)
+          .build();

Review Comment:
   There's multiple ways of initializing the event submitter context, either 
via providing an event submitter or by manually specifying the tags or with the 
job properties, so I'd rather have it go through the builder.
   
   Also since the metric tags are created using an immutable list in Gobblin it 
becomes difficult to append to, which is why the builder uses an array list and 
then creates an immutable list when the tags have been initialized. If the 
previous tags were immutable then it's impossible to keep the field for tags 
before as `final` when more tags need to be added like what was mentioned in 
the previous comments.





Issue Time Tracking
-------------------

    Worklog Id:     (was: 909512)
    Time Spent: 2.5h  (was: 2h 20m)

> Add metadata tags for events sent from Temporal to be parseable in GaaS
> -----------------------------------------------------------------------
>
>                 Key: GOBBLIN-2014
>                 URL: https://issues.apache.org/jira/browse/GOBBLIN-2014
>             Project: Apache Gobblin
>          Issue Type: Bug
>          Components: gobblin-service
>            Reporter: William Lo
>            Assignee: Abhishek Tiwari
>            Priority: Major
>          Time Spent: 2.5h
>  Remaining Estimate: 0h
>
> Gobblin's Temporal workflow launches through `ExecuteGobblinJobLauncher`, but 
> the eventSubmitter created in that class does not have the necessary metadata 
> needed in order to send events to GaaS.
> We want to populate the additional tags to read from the job props that 
> contain the information needed for these events to be readable from GaaS.



--
This message was sent by Atlassian Jira
(v8.20.10#820010)

Reply via email to