[
https://issues.apache.org/jira/browse/GOBBLIN-2014?focusedWorklogId=909490&page=com.atlassian.jira.plugin.system.issuetabpanels:worklog-tabpanel#worklog-909490
]
ASF GitHub Bot logged work on GOBBLIN-2014:
-------------------------------------------
Author: ASF GitHub Bot
Created on: 12/Mar/24 20:20
Start Date: 12/Mar/24 20:20
Worklog Time Spent: 10m
Work Description: phet commented on code in PR #3894:
URL: https://github.com/apache/gobblin/pull/3894#discussion_r1522059631
##########
gobblin-temporal/src/main/java/org/apache/gobblin/temporal/ddm/launcher/ProcessWorkUnitsJobLauncher.java:
##########
@@ -85,7 +85,9 @@ public void submitJob(List<WorkUnit> workunits) {
URI nameNodeUri = new URI(PropertiesUtils.getRequiredProp(this.jobProps,
GOBBLIN_TEMPORAL_JOB_LAUNCHER_ARG_NAME_NODE_URI));
// NOTE: `Path` is challenging for temporal to ser/de, but nonetheless
do pre-construct as `Path`, to pre-validate this prop string's contents
Path workUnitsDir = new
Path(PropertiesUtils.getRequiredProp(this.jobProps,
GOBBLIN_TEMPORAL_JOB_LAUNCHER_ARG_WORK_UNITS_DIR));
- EventSubmitterContext eventSubmitterContext = new
EventSubmitterContext(this.eventSubmitter);
+ EventSubmitterContext eventSubmitterContext = new
EventSubmitterContext.Builder()
+ .withEventSubmitter(eventSubmitter)
+ .build();
Review Comment:
actually, I did just suggest that you add a `Builder` ctor, but thinking
more, why force the use of this builder, when `new
EventSubmitterContext(eventSubmitter)` is simplest and continues to serve this
base case just fine?
Issue Time Tracking
-------------------
Worklog Id: (was: 909490)
Time Spent: 2h 10m (was: 2h)
> Add metadata tags for events sent from Temporal to be parseable in GaaS
> -----------------------------------------------------------------------
>
> Key: GOBBLIN-2014
> URL: https://issues.apache.org/jira/browse/GOBBLIN-2014
> Project: Apache Gobblin
> Issue Type: Bug
> Components: gobblin-service
> Reporter: William Lo
> Assignee: Abhishek Tiwari
> Priority: Major
> Time Spent: 2h 10m
> Remaining Estimate: 0h
>
> Gobblin's Temporal workflow launches through `ExecuteGobblinJobLauncher`, but
> the eventSubmitter created in that class does not have the necessary metadata
> needed in order to send events to GaaS.
> We want to populate the additional tags to read from the job props that
> contain the information needed for these events to be readable from GaaS.
--
This message was sent by Atlassian Jira
(v8.20.10#820010)