arjun4084346 commented on code in PR #3890:
URL: https://github.com/apache/gobblin/pull/3890#discussion_r1529288088


##########
gobblin-service/src/main/java/org/apache/gobblin/service/modules/core/GobblinServiceGuiceModule.java:
##########
@@ -193,23 +193,28 @@ public void configure(Binder binder) {
       binder.bind(FlowLaunchHandler.class);
     }
 
+    // Note: only one SchedulerFactory instance should exist per JVM

Review Comment:
   then why not `.in(Singleton.class);` ?



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: [email protected]

For queries about this service, please contact Infrastructure at:
[email protected]

Reply via email to