arjun4084346 commented on code in PR #3890:
URL: https://github.com/apache/gobblin/pull/3890#discussion_r1529551884
##########
gobblin-runtime/src/main/java/org/apache/gobblin/runtime/api/DagActionStore.java:
##########
@@ -51,30 +52,53 @@ public FlowId getFlowId() {
*/
public DagAction updateFlowExecutionId(long eventTimeMillis) {
return new DagAction(this.getFlowGroup(), this.getFlowName(),
- String.valueOf(eventTimeMillis), this.getFlowActionType());
+ String.valueOf(eventTimeMillis), this.getJobName(),
this.getDagActionType());
}
}
/**
- * Check if an action exists in dagAction store by flow group, flow name and
flow execution id.
+ * Check if an action exists in dagAction store by flow group, flow name,
flow execution id, and job name.
* @param flowGroup flow group for the dag action
* @param flowName flow name for the dag action
* @param flowExecutionId flow execution for the dag action
- * @param flowActionType the value of the dag action
+ * @param jobName job name for the dag action
+ * @param dagActionType the value of the dag action
* @throws IOException
*/
- boolean exists(String flowGroup, String flowName, String flowExecutionId,
FlowActionType flowActionType) throws IOException, SQLException;
+ boolean exists(String flowGroup, String flowName, String flowExecutionId,
String jobName, DagActionType dagActionType) throws IOException, SQLException;
+
+ /**
+ * Check if an action exists in dagAction store by flow group, flow name,
and flow execution id, it assumes jobName is
+ * empty ("").
+ * @param flowGroup flow group for the dag action
+ * @param flowName flow name for the dag action
+ * @param flowExecutionId flow execution for the dag action
+ * @param dagActionType the value of the dag action
+ * @throws IOException
+ */
+ boolean exists(String flowGroup, String flowName, String flowExecutionId,
DagActionType dagActionType) throws IOException, SQLException;
/**
* Persist the dag action in {@link DagActionStore} for durability
* @param flowGroup flow group for the dag action
* @param flowName flow name for the dag action
* @param flowExecutionId flow execution for the dag action
- * @param flowActionType the value of the dag action
+ * @param jobName job name for the dag action
+ * @param dagActionType the value of the dag action
+ * @throws IOException
+ */
+ void addDagAction(String flowGroup, String flowName, String flowExecutionId,
String jobName, DagActionType dagActionType) throws IOException;
Review Comment:
should we have named these two methods, "addJobDagAction" and
"addFlowDagAction"?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]