umustafi commented on code in PR #3890:
URL: https://github.com/apache/gobblin/pull/3890#discussion_r1529450812


##########
gobblin-service/src/main/java/org/apache/gobblin/service/modules/orchestration/DagManagementTaskStreamImpl.java:
##########
@@ -53,14 +53,18 @@ public class DagManagementTaskStreamImpl implements 
DagManagement, DagTaskStream
 
   @Inject(optional=true)
   protected Optional<DagActionStore> dagActionStore;
+  protected ReminderSettingDagProcLeaseArbiter 
reminderSettingDagProcLeaseArbiter;
   @Inject
   private static final int MAX_HOUSEKEEPING_THREAD_DELAY = 180;
   private final BlockingQueue<DagActionStore.DagAction> dagActionQueue = new 
LinkedBlockingQueue<>();
 
+  // TODO: need to pass reference to DagProcLeaseArbiter without creating a 
circular reference in Guice
   @Inject
-  public DagManagementTaskStreamImpl(Config config, Optional<DagActionStore> 
dagActionStore) {
+  public DagManagementTaskStreamImpl(Config config, Optional<DagActionStore> 
dagActionStore,
+      ReminderSettingDagProcLeaseArbiter reminderSettingDagProcLeaseArbiter) {

Review Comment:
   updated guice module for this and all related classes



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: [email protected]

For queries about this service, please contact Infrastructure at:
[email protected]

Reply via email to