umustafi commented on code in PR #3890:
URL: https://github.com/apache/gobblin/pull/3890#discussion_r1529309435


##########
gobblin-runtime/src/main/java/org/apache/gobblin/runtime/api/DagActionStore.java:
##########
@@ -51,30 +52,53 @@ public FlowId getFlowId() {
      */
     public DagAction updateFlowExecutionId(long eventTimeMillis) {
       return new DagAction(this.getFlowGroup(), this.getFlowName(),
-          String.valueOf(eventTimeMillis), this.getFlowActionType());
+          String.valueOf(eventTimeMillis), this.getJobName(), 
this.getDagActionType());
     }
   }
 
 
   /**
-   * Check if an action exists in dagAction store by flow group, flow name and 
flow execution id.
+   * Check if an action exists in dagAction store by flow group, flow name, 
flow execution id, and job name.
    * @param flowGroup flow group for the dag action
    * @param flowName flow name for the dag action
    * @param flowExecutionId flow execution for the dag action
-   * @param flowActionType the value of the dag action
+   * @param jobName job name for the dag action

Review Comment:
   We want to make certain actions at a job level instead of flow level (think 
mainly for flow launch). We may have a case where there are multi-hop jobs with 
even multiple concurrent jobs to be launched at once (ie jobs A and B both to 
be launched before job C let's say) . In order to make error handling / retries 
easier we want job level flow launch actions so if job launch A succeeds but B 
fails only job B can be retried by another instance or the same instance rather 
than having to do extra work and relaunch job A that already succeeded or have 
to intelligently evaluate work to do.



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: [email protected]

For queries about this service, please contact Infrastructure at:
[email protected]

Reply via email to