[
https://issues.apache.org/jira/browse/GOBBLIN-2065?focusedWorklogId=918445&page=com.atlassian.jira.plugin.system.issuetabpanels:worklog-tabpanel#worklog-918445
]
ASF GitHub Bot logged work on GOBBLIN-2065:
-------------------------------------------
Author: ASF GitHub Bot
Created on: 09/May/24 01:31
Start Date: 09/May/24 01:31
Worklog Time Spent: 10m
Work Description: phet opened a new pull request, #3948:
URL: https://github.com/apache/gobblin/pull/3948
Dear Gobblin maintainers,
Please accept this PR. I understand that it will not be reviewed until I
have checked off all the steps below!
### JIRA
- [ ] My PR addresses the following [Gobblin
JIRA](https://issues.apache.org/jira/browse/GOBBLIN/) issues and references
them in the PR title. For example, "[GOBBLIN-XXX] My Gobblin PR"
- https://issues.apache.org/jira/browse/GOBBLIN-2065
### Description
- [ ] Here are some details about my PR, including screenshots (if
applicable):
We continue to face the "Too many connections" error while running
`gobblin-service` tests; see, e.g. - https://github.com/apache/gobblin/pull/3944
this shows up as
```
java.io.IOException: Failure creation table TestDagStateStore
...
Caused by: java.sql.SQLNonTransientConnectionException: Too many connections
...
```
Adjusting the server variable `max_connections` (in
[TestMetastoreDatabaseServer.java](https://github.com/apache/gobblin/compare/master...phet:gobblin:fix_gobblin-service_tests_too_many_connections?expand=1#diff-3a1f64166bc336495b2d153fe1f8bc0fdc9dd28450cb8de1d32578c2f2727517))
to `501` has fixed local execution.
While debugging, I realized not all of the `@AfterClass` annotations use
`(alwaysRun = true)`, so following on to the recent mods in
https://github.com/apache/gobblin/pull/3946
### Tests
- [ ] My PR adds the following unit tests __OR__ does not need testing for
this extremely good reason:
updated tests herein
### Commits
- [ ] My commits all reference JIRA issues in their subject lines, and I
have squashed multiple commits if they address the same issue. In addition, my
commits follow the guidelines from "[How to write a good git commit
message](http://chris.beams.io/posts/git-commit/)":
1. Subject is separated from body by a blank line
2. Subject is limited to 50 characters
3. Subject does not end with a period
4. Subject uses the imperative mood ("add", not "adding")
5. Body wraps at 72 characters
6. Body explains "what" and "why", not "how"
Issue Time Tracking
-------------------
Worklog Id: (was: 918445)
Time Spent: 20m (was: 10m)
> close ITestMetastoreDatabase in all tests
> -----------------------------------------
>
> Key: GOBBLIN-2065
> URL: https://issues.apache.org/jira/browse/GOBBLIN-2065
> Project: Apache Gobblin
> Issue Type: Bug
> Reporter: Arjun Singh Bora
> Priority: Major
> Time Spent: 20m
> Remaining Estimate: 0h
>
> if test db is not closed, it will eventually give `TooManyConnections`
> exception
--
This message was sent by Atlassian Jira
(v8.20.10#820010)
