[ 
https://issues.apache.org/jira/browse/GOBBLIN-2065?focusedWorklogId=918447&page=com.atlassian.jira.plugin.system.issuetabpanels:worklog-tabpanel#worklog-918447
 ]

ASF GitHub Bot logged work on GOBBLIN-2065:
-------------------------------------------

                Author: ASF GitHub Bot
            Created on: 09/May/24 01:38
            Start Date: 09/May/24 01:38
    Worklog Time Spent: 10m 
      Work Description: phet commented on code in PR #3948:
URL: https://github.com/apache/gobblin/pull/3948#discussion_r1594863028


##########
gobblin-metastore/src/test/java/org/apache/gobblin/metastore/testing/TestMetastoreDatabaseServer.java:
##########
@@ -96,6 +96,8 @@ class TestMetastoreDatabaseServer implements Closeable {
         .withPort(this.dbPort)
         .withUser(this.dbUserName, this.dbUserPassword)
         .withServerVariable("explicit_defaults_for_timestamp", "off")
+        // default `max_connections` is apparently 151 - see: 
https://dev.mysql.com/doc/refman/8.0/en/server-system-variables.html#sysvar_max_connections
+        .withServerVariable("max_connections", "501")

Review Comment:
   this seemed to be the deciding factor for successful local execution.   most 
of the other changes are more cosmetic and for uniformity





Issue Time Tracking
-------------------

    Worklog Id:     (was: 918447)
    Time Spent: 40m  (was: 0.5h)

> close ITestMetastoreDatabase in all tests
> -----------------------------------------
>
>                 Key: GOBBLIN-2065
>                 URL: https://issues.apache.org/jira/browse/GOBBLIN-2065
>             Project: Apache Gobblin
>          Issue Type: Bug
>            Reporter: Arjun Singh Bora
>            Priority: Major
>          Time Spent: 40m
>  Remaining Estimate: 0h
>
> if test db is not closed, it will eventually give `TooManyConnections` 
> exception



--
This message was sent by Atlassian Jira
(v8.20.10#820010)

Reply via email to