[ 
https://issues.apache.org/jira/browse/GOBBLIN-2065?focusedWorklogId=918467&page=com.atlassian.jira.plugin.system.issuetabpanels:worklog-tabpanel#worklog-918467
 ]

ASF GitHub Bot logged work on GOBBLIN-2065:
-------------------------------------------

                Author: ASF GitHub Bot
            Created on: 09/May/24 03:18
            Start Date: 09/May/24 03:18
    Worklog Time Spent: 10m 
      Work Description: phet commented on code in PR #3948:
URL: https://github.com/apache/gobblin/pull/3948#discussion_r1594916582


##########
gobblin-service/src/test/java/org/apache/gobblin/service/modules/core/GobblinServiceHATest.java:
##########
@@ -255,6 +251,8 @@ public void cleanUp() throws Exception {
     cleanUpDir(COMMON_SPEC_STORE_PARENT_DIR);
 
     mysql.stop();
+    // `.close()` to avoid (in the aggregate, across multiple suites) - 
java.sql.SQLNonTransientConnectionException: Too many connections
+    testMetastoreDatabase.close();

Review Comment:
   aah, I misunderstood the gist of your Q earlier and now see what you were 
getting at.  just made the change





Issue Time Tracking
-------------------

    Worklog Id:     (was: 918467)
    Time Spent: 1h 50m  (was: 1h 40m)

> close ITestMetastoreDatabase in all tests
> -----------------------------------------
>
>                 Key: GOBBLIN-2065
>                 URL: https://issues.apache.org/jira/browse/GOBBLIN-2065
>             Project: Apache Gobblin
>          Issue Type: Bug
>            Reporter: Arjun Singh Bora
>            Priority: Major
>          Time Spent: 1h 50m
>  Remaining Estimate: 0h
>
> if test db is not closed, it will eventually give `TooManyConnections` 
> exception



--
This message was sent by Atlassian Jira
(v8.20.10#820010)

Reply via email to